Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Errkit migration 6 (pkg/secrets) #3173

Merged
merged 3 commits into from
Oct 7, 2024
Merged

Conversation

e-sumin
Copy link
Contributor

@e-sumin e-sumin commented Oct 4, 2024

Change Overview

Migrate pkg/secrets to errkit

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test
  • 🏗️ Build

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@e-sumin e-sumin changed the title chore: Errkit migration 6 (pkg/blockstorage) #3170 chore: Errkit migration 6 (pkg/blockstorage) Oct 4, 2024
@hairyhum hairyhum changed the title chore: Errkit migration 6 (pkg/blockstorage) chore: Errkit migration 6 (pkg/secrets) Oct 4, 2024
Copy link
Contributor

@hairyhum hairyhum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@e-sumin e-sumin added the kueue label Oct 7, 2024
@mergify mergify bot merged commit 7b2bb9c into master Oct 7, 2024
18 checks passed
@mergify mergify bot deleted the errkit_migration_6_secrets branch October 7, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants